Archive Tool update  [SUBMITTED]

Moderator: SecondMan

User avatar
Movalex
Sir Requestalot
Posts: 154
Joined: Fri Nov 03, 2017 5:36 am
Answers: 2
Been thanked: 44 times
Contact:

Archive Tool update

#1

Post by Movalex » Thu Mar 21, 2019 9:28 am

Hi!
There's a typo in Archive Comp script in EyeonLegacy Collection of Reactor.
Output file is saved without extension.
changes:

line 893:
  1. - output_composition = output_root .. composition:GetAttrs().COMPS_Name
  2. + output_composition = output_root .. composition:GetAttrs().COMPS_Name .. '.comp'
See the changes proposed in https://gitlab.com/WeSuckLess/Reactor/merge_requests/59
You do not have the required permissions to view the files attached to this post.

User avatar
SecondMan
Site Admin
Posts: 3769
Joined: Thu Jul 31, 2014 5:31 pm
Answers: 7
Location: Vancouver, Canada
Been thanked: 146 times
Contact:

Re: Archive Tool update

#2

Post by SecondMan » Thu Mar 21, 2019 11:07 am

Submitted, well spotted thanks!

Since the commit was lumped together with other unrelated ones I've gone ahead and done this one separately. I also changed the release date in the Atom file. Nice bit of spring cleaning there ;)

Your Merge requests are great but I'd ask to keep things a little separate for clarity and ease.

User avatar
Movalex
Sir Requestalot
Posts: 154
Joined: Fri Nov 03, 2017 5:36 am
Answers: 2
Been thanked: 44 times
Contact:

Re: Archive Tool update

#3

Post by Movalex » Tue Aug 06, 2019 4:29 am

Another update to Archive comp script:
Add FileLUTs export

https://gitlab.com/WeSuckLess/Reactor/merge_requests/92

Image
You do not have the required permissions to view the files attached to this post.
Last edited by Movalex on Tue Aug 06, 2019 5:18 am, edited 1 time in total.

User avatar
SecondMan
Site Admin
Posts: 3769
Joined: Thu Jul 31, 2014 5:31 pm
Answers: 7
Location: Vancouver, Canada
Been thanked: 146 times
Contact:

Re: Archive Tool update

#4

Post by SecondMan » Tue Aug 06, 2019 4:34 am

Ah yes nice one :)

Looking at the merge request it seems you haven't updated your version number though. Important for updating in Reactor...

User avatar
Movalex
Sir Requestalot
Posts: 154
Joined: Fri Nov 03, 2017 5:36 am
Answers: 2
Been thanked: 44 times
Contact:

Re: Archive Tool update

#5

Post by Movalex » Tue Aug 06, 2019 4:49 am

done!

User avatar
Movalex
Sir Requestalot
Posts: 154
Joined: Fri Nov 03, 2017 5:36 am
Answers: 2
Been thanked: 44 times
Contact:

Re: Archive Tool update

#6

Post by Movalex » Thu Aug 08, 2019 3:00 am

I also realized, that current version os Archive Comp script incorrectly parses a movie formats if the filepath contains a . symbol in it.
For instance, if the comp is placed in C:\Users\User\Desktop\test.test\ folder, eyeon.getextension(path) will parse the extension incorrectly, and the file will be considered an image sequence instead. We should use eyeon.parseFilename(path).Extension instead.

https://gitlab.com/WeSuckLess/Reactor/c ... e1f4d8829c

User avatar
AndrewHazelden
Fusionator
Posts: 1529
Joined: Fri Apr 03, 2015 3:20 pm
Answers: 8
Location: West Dover, Nova Scotia, Canada
Been thanked: 98 times
Contact:

Re: Archive Tool update

#7

Post by AndrewHazelden » Thu Aug 08, 2019 5:56 am

Movalex wrote:
Thu Aug 08, 2019 3:00 am
I also realized, that current version os Archive Comp script incorrectly parses a movie formats if the filepath contains a . symbol in it.
For instance, if the comp is placed in C:\Users\User\Desktop\test.test\ folder, eyeon.getextension(path) will parse the extension incorrectly, and the file will be considered an image sequence instead. We should use eyeon.parseFilename(path).Extension instead.

https://gitlab.com/WeSuckLess/Reactor/c ... e1f4d8829c
For your question on the GitLab commit comments section, likely only OG Eyeon staff could answer it.

So that would be WSL people like Izyk, PeterLoveday, SirEdric, or BFloch. :)

User avatar
AndrewHazelden
Fusionator
Posts: 1529
Joined: Fri Apr 03, 2015 3:20 pm
Answers: 8
Location: West Dover, Nova Scotia, Canada
Been thanked: 98 times
Contact:

Re: Archive Tool update

#8

Post by AndrewHazelden » Thu Aug 08, 2019 6:21 am

Hi @movalex,

Would you be up to try doing a Python port of the Eyeon Legacy "Archive Composition" script? I think a lot of Fusion newcomers who are intimidated by Lua for the first time would love to see how this kind of script looks as native Python code. It would be like a rosetta stone for people to learn how to script a Fusion pipeline in Py vs what the Lua code looks like.

As an example, the SplitEXR_Ultra script port to Python done by @bryanfordney recently was pretty epic. 👍

User avatar
SecondMan
Site Admin
Posts: 3769
Joined: Thu Jul 31, 2014 5:31 pm
Answers: 7
Location: Vancouver, Canada
Been thanked: 146 times
Contact:

Re: Archive Tool update  [SUBMITTED]

#9

Post by SecondMan » Thu Aug 08, 2019 7:15 am

And the update is available in Reactor now! :cheer:
AndrewHazelden wrote:
Thu Aug 08, 2019 5:56 am
For your question on the GitLab commit comments section, likely only OG Eyeon staff could answer it.
I'll have a try. The question was:

Code: Select all

    for i = 1, table.getn(attrs.TOOLST_Clip_Name) do
BTW, why is this for loop here? The table attrs.TOOLST_Clip_Name always have 1 element.

Clip List support in Loaders. That was another nifty feature of Fusion that didn't make the cut in Fusion 8. I used it extensively back in the day when I had written an exposure sheet converter to import Take 5 line tests in Fusion (my very first - and very, very dirty - script!).

I would still like to have that back actually, though I guess you can work around it with IFL files.

User avatar
Movalex
Sir Requestalot
Posts: 154
Joined: Fri Nov 03, 2017 5:36 am
Answers: 2
Been thanked: 44 times
Contact:

Re: Archive Tool update

#10

Post by Movalex » Thu Aug 08, 2019 8:12 am

AndrewHazelden wrote:
Thu Aug 08, 2019 6:21 am
Would you be up to try doing a Python port of the Eyeon Legacy "Archive Composition" script?
This is exactly what I was thinking about, trying to wrap my head around this old cript. Besides lua has poor Unicode handling, and each time I have a single Cyrillic character in a path, archive script does not work.