Hello 2021!

Suck Less Audio File Modifier  [SUBMITTED]

Moderator: SecondMan

User avatar
JiiPii
Fusioneer
Posts: 139
Joined: Tue Mar 03, 2020 8:34 am
Answers: 1
Been thanked: 1 time

Suck Less Audio File Modifier

#1

Post by JiiPii »

I admit I was a bit comfortable because actually it's really better to have a separate post for each submission.
So here is the update for the Suck Less Audio Modifier V2.7

- WAV file with Junk Chunk: audio rendering with DR is possible
- optimize "sampleRead"
- Filter string in Loadfile: Only * .wav files are displayed
- Tooltips of mode options changed
- Show errors in label
- Infos about bitrate and count of frames
- function getHeader optimized
- Add Filter (LP, BP, HP) for Slot1
- Add MapPath to readAll: Now you can use DR / Fusion MapPath
- Errordetect: Wrong bit-depth: Avoid loading 24 / 32bit Wavefiles and display error
com.PieterVanHoute.SuckLessAudio.zip
@SecondMan - take as much time as you need - no stress -
I looked at the date in Atomizer, there I set the date to September 4
You do not have the required permissions to view the files attached to this post.

User avatar
SecondMan
Site Admin
Posts: 4781
Joined: Thu Jul 31, 2014 5:31 pm
Answers: 30
Location: Vancouver, Canada
Been thanked: 18 times
Contact:

Re: Suck Less Audio File Modifier

#2

Post by SecondMan »

Hi @JiiPii - I still owe you a bit of a code review. Haven't had the chance yet. I did open up the Fuse for a quick first impression. The date I referred to earlier is the one in the Fuse itself, not in the Atom file.

I did notice that there are some changes in indentation, like 2-space tabs instead of 4-space ones. Could I ask you to do a clean-up pass please, so it's all consistent?

That's all I have for now :)

User avatar
JiiPii
Fusioneer
Posts: 139
Joined: Tue Mar 03, 2020 8:34 am
Answers: 1
Been thanked: 1 time

Re: Suck Less Audio File Modifier

#3

Post by JiiPii »

Hello @SecondMan

Sorry for incorrect indentation. I use the Lua Development Tool and somehow it all moves with 2 spaces. I ran a beautyfier over there and now it looks good in the "normal" editor. I also corrected a naming error. I had forgotten the "junk" in the name of the FuRegisterClass
com.PieterVanHoute.SuckLessAudio.zip
You do not have the required permissions to view the files attached to this post.

User avatar
SecondMan
Site Admin
Posts: 4781
Joined: Thu Jul 31, 2014 5:31 pm
Answers: 30
Location: Vancouver, Canada
Been thanked: 18 times
Contact:

Re: Suck Less Audio File Modifier

#4

Post by SecondMan »

JiiPii wrote: Wed Sep 30, 2020 4:00 pmI ran a beautyfier
Just wanted to point something out - a beautifier may solve the indentation issue, but what it also did is completely change the layout of how classes are historically used in Fusion Lua code...

Consider this example of an input:

Code: Select all

	InOutType = self:AddInput("Output Type", "OutputType", {
		LINKID_DataType = "FuID",
		INPID_InputControl = "MultiButtonIDControl",
		INPID_DefaultID = "Sample",
		INP_DoNotifyChanged  = true,
		MBTNC_StretchToFit = true,
		MBTNC_ForceButtons = true,
		{ MBTNC_AddButton = "Sample Values", MBTNCID_AddID = "Sample", MBTNCS_ToolTip = "Outputs the values in the sample file.", },
		{ MBTNC_AddButton = "Sample Modifies Input", MBTNCID_AddID = "Modified", MBTNCS_ToolTip = "Adds the values in the sample file to the input parameter.", },
		})
which becomes:

Code: Select all

    InOutType =
        self:AddInput(
        "Output Type",
        "OutputType",
        {
            LINKID_DataType = "FuID",
            INPID_InputControl = "MultiButtonIDControl",
            INPID_DefaultID = "Sample",
            INP_DoNotifyChanged = true,
            MBTNC_StretchToFit = true,
            MBTNC_ForceButtons = true,
            {
                MBTNC_AddButton = "Sample Values",
                MBTNCID_AddID = "Sample",
                MBTNCS_ToolTip = "Outputs the values in the sample file."
            },
            {
                MBTNC_AddButton = "Add Offset",
                MBTNCID_AddID = "Modified",
                MBTNCS_ToolTip = "Adds the values in the sample file plus offset"
            }
        }
    )
You could argue for either, but the below looks unlike anything else here, or in VFXPedia, or other sources online. In this particular case we're also working together on one piece of code, so if later I wanted to go back to developing this fuse I'd have to redo the layout again to be familiar/comfortable with the code.

Any compare tool out there also marks everything as changed, which makes code reviews between versions pretty much impossible.

Any chance you could do just the indentations please?

User avatar
JiiPii
Fusioneer
Posts: 139
Joined: Tue Mar 03, 2020 8:34 am
Answers: 1
Been thanked: 1 time

Re: Suck Less Audio File Modifier

#5

Post by JiiPii »

I have to honestly admit that after the beautifier I only looked for my new code in the process function, it was certainly too fast. Ashes on my head (I hope you can understand the phrase). I was also a little irritated and can understand that very well.
I have now merged the two parts, the create part has the usual appearance and the process part of the beautifier, whereby I have set the usual ones for the function calls and the large if queries.
I also did a code comparison between 2.6 and 2.7 and now you can understand my changes very well.
com.PieterVanHoute.SuckLessAudio.zip
You do not have the required permissions to view the files attached to this post.

User avatar
SecondMan
Site Admin
Posts: 4781
Joined: Thu Jul 31, 2014 5:31 pm
Answers: 30
Location: Vancouver, Canada
Been thanked: 18 times
Contact:

Re: Suck Less Audio File Modifier

#6

Post by SecondMan »

JiiPii wrote: Thu Oct 15, 2020 1:16 amAshes on my head (I hope you can understand the phrase).
Haha, I do :) - not to worry, though, this is all good pro(c)(gr)ess!

Let's get it out in the wild and see what happens - update available in Reactor! Thanks! :cheer:

User avatar
JiiPii
Fusioneer
Posts: 139
Joined: Tue Mar 03, 2020 8:34 am
Answers: 1
Been thanked: 1 time

Re: Suck Less Audio File Modifier  [SUBMITTED]

#7

Post by JiiPii »

For reasons inexplicable to me, a letter cheated in the fuse shortly before packing it :banghead: (I didn't put it in there consciously :roll: ) and this led to the error.
I beg your apologies.

Here is the corrected Version
com.PieterVanHoute.SuckLessAudio.zip
You do not have the required permissions to view the files attached to this post.

User avatar
SecondMan
Site Admin
Posts: 4781
Joined: Thu Jul 31, 2014 5:31 pm
Answers: 30
Location: Vancouver, Canada
Been thanked: 18 times
Contact:

Re: Suck Less Audio File Modifier

#8

Post by SecondMan »

Good timing! I was just looking into this. This indeed fixes it and it's available in Reactor now - thanks! :cheer: